46. Permutations #50
Open
46. Permutations #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokuhirat
reviewed
Aug 18, 2025
| permuteHelper(result, nums, 0); | ||
| return result; | ||
| } | ||
| void permuteHelper(vector<vector<int>>& result, vector<int>& nums, int decided_until) { |
There was a problem hiding this comment.
private でも問題ないでしょうか。
results は出力なので引数の最後にした方が良いかもしれません。
https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs
Owner
Author
There was a problem hiding this comment.
privateで良いと思います。入れるのを忘れてしまっていました。
出力を最後に持ってくるのが推奨されているというのは知りませんでした。ありがとうございます。
ryosuketc
reviewed
Aug 18, 2025
| permuteHelper(result, nums, 0); | ||
| return result; | ||
| } | ||
| void permuteHelper(vector<vector<int>>& result, vector<int>& nums, int decided_until) { |
tokuhirat
reviewed
Aug 18, 2025
| for (int i = decided_until; i < nums.size(); ++i) { | ||
| swap(nums[decided_until], nums[i]); | ||
| permuteHelper(result, nums, decided_until + 1); | ||
| swap(nums[decided_until], nums[i]); |
There was a problem hiding this comment.
decided_until は swap_index のように感じました。ここまで決めたんだという意味は落ちてしまいますが、、、
tokuhirat
reviewed
Aug 18, 2025
| swap(nums[decided_until], nums[i]); | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
重複を含む入力に対して正しく（重複は含まれる）動くのはこのコードだけでしょうか。
Owner
Author
There was a problem hiding this comment.
たしかに、その視点はありませんでした。setを使った解法は動かないように思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/permutations/description/